Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom icon support fill null close #2654 #2699

Merged
merged 1 commit into from
May 7, 2024
Merged

feat: custom icon support fill null close #2654 #2699

merged 1 commit into from
May 7, 2024

Conversation

Volankey
Copy link
Contributor

@Volankey Volankey commented May 7, 2024 •
edited
Loading

๐Ÿ‘€ PR includes

โœจ Feature

  • New feature

๐ŸŽจ Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

๐Ÿ› Bugfix

  • Solve the issue and close #0

๐Ÿ”ง Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

๐Ÿ“ Description

customSVGIcons ๆ”ฏๆŒ fill ไผ  null๏ผŒๆŸไบ›ๅœบๆ™ฏไธ‹้œ€่ฆไฟๆŒๅ›พๆ ‡ๅŽŸๆœฌ็š„้ขœ่‰ฒ๏ผˆไพ‹ๅฆ‚ๅฝฉ่‰ฒๅ›พๆ ‡็ญ‰๏ผ‰

Close #2654.

๐Ÿ–ผ๏ธ Screenshot

Before After
โŒ โœ…

๐Ÿ”— Related issue link

๐Ÿ” Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
antvis-s2 โŒ Failed (Inspect) May 7, 2024 9:00am

@github-actions github-actions bot added next 2.0-next ็‰ˆๆœฌ็š„้—ฎ้ข˜ pr(feature) new feature labels May 7, 2024
@lijinke666
Copy link
Member

#2700

@lijinke666 lijinke666 merged commit bdbd1b3 into antvis:next May 7, 2024
14 of 15 checks passed
@lijinke666
Copy link
Member

๐ŸŽ‰ This PR is included in version @antv/s2-v2.0.0-next.20 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijinke666 lijinke666 lijinke666 approved these changes

@wjgogogo wjgogogo Awaiting requested review from wjgogogo

@wuhaiyang wuhaiyang Awaiting requested review from wuhaiyang

Assignees

@Volankey Volankey

Labels
next 2.0-next ็‰ˆๆœฌ็š„้—ฎ้ข˜ pr(feature) new feature released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Volankey @lijinke666 @RobotVol